Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tune] Overwrite files on restore (replace instead of rename) #28404

Merged
merged 1 commit into from
Sep 9, 2022
Merged

[tune] Overwrite files on restore (replace instead of rename) #28404

merged 1 commit into from
Sep 9, 2022

Conversation

krfricke
Copy link
Contributor

@krfricke krfricke commented Sep 9, 2022

Signed-off-by: Kai Fricke [email protected]

Why are these changes needed?

Windows complains when files already exist on restore, so we should replace instead.

Related issue number

Closes #28402

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@krfricke krfricke mentioned this pull request Sep 9, 2022
Closed
@xwjiang2010
Copy link
Contributor

Ah thanks!
A good learn from me :)
https://stackoverflow.com/questions/69363867/difference-between-os-replace-and-os-rename

@krfricke krfricke merged commit 95cbe52 into ray-project:master Sep 9, 2022
@krfricke krfricke deleted the tune/tuner-replace branch September 10, 2022 01:22
ilee300a pushed a commit to ilee300a/ray that referenced this pull request Sep 12, 2022
@krfricke @ilee300a
[tune] Overwrite files on restore (replace instead of rename) (ray-pr…
dd17b27 
…oject#28404)

Windows complains when files already exist on restore, so we should replace instead.

Signed-off-by: Kai Fricke <[email protected]>
Signed-off-by: ilee300a <[email protected]>
justinvyu pushed a commit to justinvyu/ray that referenced this pull request Sep 14, 2022
@krfricke @justinvyu
[tune] Overwrite files on restore (replace instead of rename) (ray-pr…
6fedb39 
…oject#28404)

Windows complains when files already exist on restore, so we should replace instead.

Signed-off-by: Kai Fricke <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xwjiang2010 xwjiang2010 xwjiang2010 approved these changes

Assignees

@xwjiang2010 xwjiang2010

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ray.tune.impl.tuner_internal.py
2 participants
@krfricke @xwjiang2010